Adding eventbridge-pipes-ddbstream-sfn-terraform pattern #2445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisms
requested changes
Sep 12, 2024
| 1. Stream logs from the Step Functions log group | ||
|
|
||
| ``` | ||
| sam logs --cw-log-group <LogGroup Name> --tail |
There was a problem hiding this comment.
Add note to use SFNLog output in the command.
There was a problem hiding this comment.
Sorry, I don't understand. What do you mean?
There was a problem hiding this comment.
I mean add an instruction to use the value from SFNLog in the sam logs command (i.e. replace LogGroup Name with the value of SFNLog).
There was a problem hiding this comment.
The LogGroup name is dynamically generated using a combination of the Stack name and a randomly generated string. I would like to keep the naming convention generic.
|
New changes added. Please, could you review now? |
ellisms
requested changes
Sep 23, 2024
|
|
||
| ## Testing | ||
|
|
||
| 1. Stream logs from the Step Functions log group |
There was a problem hiding this comment.
Suggested change
| 1. Stream logs from the Step Functions log group | |
| 1. Stream logs from the Step Functions log group. Replace `<LogGroup Name>` with the `SFNLog` output value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding terraform version of eventbridge-pipes-ddbstream-sfn pattern
https://serverlessland.com/patterns/eventbridge-pipes-ddbstream-sfn
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.